adjusting variable names, fixing errors

tasks/pkgs/bashls.yml

@@ -9,7 +9,7 @@
 - name: Set bashls default facts # {{{
   ansible.builtin.set_fact:
     bashls:
-      install_methods:
+      methods:
         - source
       npm_pkg:
         name: bash-language-server
@@ -22,13 +22,13 @@
   block:
     - name: Set bashls install method
       when:
-        - bashls_install_method is undefined
+        - bashls_imethod is undefined
       ansible.builtin.set_fact:
-        bashls_install_method: "{{ install_method if install_method in bashls.install_methods else bashls.install_methods[0] }}"
+        bashls_imethod: "{{ imethod if imethod in bashls.methods else bashls.methods[0] }}"
 
     - name: Configure bashls source install
       when:
-        - bashls_install_method == 'source'
+        - bashls_imethod == 'source'
       block:
         - name: Set bashls npm_pkg config
           ansible.builtin.set_fact:
@@ -41,6 +41,10 @@
           ansible.builtin.set_fact:
             pkg_npm: "{{ pkg_npm + [bashls_npm_pkg] }}"
 
+        - name: Finalise bashls source install
+          ansible.builtin.set_fact:
+            bashls_install: "{{ bashls_imethod }}={{ bashls_npm_pkg }}"
+
     - name: Set bashls_configured
       ansible.builtin.set_fact:
-        __configured: "{{ __configured | combine( { 'bashls': bashls_install_method } ) }}"
+        __configured: "{{ __configured | combine( { 'bashls': bashls_install } ) }}"